preventing double slash in the api_url#1596
Closed
HTSagara wants to merge 1 commit intoslackapi:issue-#1541from
Closed
preventing double slash in the api_url#1596HTSagara wants to merge 1 commit intoslackapi:issue-#1541from
HTSagara wants to merge 1 commit intoslackapi:issue-#1541from
Conversation
11 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue-#1541 #1596 +/- ##
============================================
Coverage 84.92% 84.92%
============================================
Files 113 113
Lines 12628 12630 +2
============================================
+ Hits 10724 10726 +2
Misses 1904 1904 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Contributor
|
We reverted the previous commit just to unblock potential future releases; would you mind pulling in the original changes / fixes for edge cases / test updates into one PR? |
Contributor
Author
|
Hi @vegeris , I will do that. |
5 tasks
Contributor
|
Closing this PR as the change will be covered in #1598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses issue #1595 by ensuring that URLs generated for Slack API requests are correctly formatted to prevent double slashes (
//) cause by the previous PR #1594 . The issue occurs when thebase_urlends with a trailing slash (/) and theapi_methodstarts with a leading slash (/). This PR modifies the_get_urlfunction to handle such cases by trimming the trailing slash from thebase_urlwhen necessary.Testing
Run either
./scripts/run_validation.shor./scripts/run_unit_tests.sh tests/web/test_web_client.pyCategory
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.